Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support of Nextcloud 27 #322

Merged
merged 4 commits into from
Jul 10, 2024
Merged

drop support of Nextcloud 27 #322

merged 4 commits into from
Jul 10, 2024

Conversation

andrey18106
Copy link
Collaborator

@andrey18106 andrey18106 commented Jul 10, 2024 •
edited
Loading

Dropping Nextcloud 27 support.

Docs updates and changes will be in another PR.

@andrey18106
drop support of Nextcloud 27
7e36f31 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106
update changelog
6c16d28 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
@andrey18106
update actions
aabf94b 
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
bigcat88
bigcat88 requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Exception":"Exception","Message":"Class \"OCP\\Notification\\UnknownNotificationException\" not found in file '/home/runner/work/app_api/app_api/apps/notifications/lib/Notifier/AdminNotifications.php' line 60"

@bigcat88
CI: corrected notifications app version
c041e71 
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
@andrey18106 andrey18106 marked this pull request as ready for review July 10, 2024 17:22
@andrey18106 andrey18106 merged commit ca4c14c into main Jul 10, 2024
30 checks passed
@andrey18106 andrey18106 deleted the nc-27-drop-support branch July 10, 2024 17:23
andrey18106 added a commit that referenced this pull request Jul 23, 2024
@andrey18106
Revert "drop support of Nextcloud 27 (#322)"
2b20925 
This reverts commit ca4c14c

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
andrey18106 added a commit that referenced this pull request Jul 23, 2024
@andrey18106
Revert "drop support of Nextcloud 27 (#322)" (#335)
91e2b6d 
This reverts commit ca4c14c.

We need this to keep the #327 included in NC 27.

We'll drop it's support after AppAPI 3.0.0.

---------

Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigcat88 bigcat88 bigcat88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrey18106 @bigcat88