Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CoreQueryBuilder): Use correct member entry for circle as initiator #1758

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(CoreQueryBuilder): Use correct member entry for circle as initiator #1758

wants to merge 3 commits into from
+209 −32

Commits on Nov 20, 2024

  1. fix(CoreQueryBuilder): Use correct member entry for circle as initiator 

    Before, the member entry that matched the `singleId` of the user and
`level = 9` was used as initiator, which in practice means the member
entry for the internal user circle of the user most of the time.

Instead, we want to use the member entry that matches `singleId` of
the user and `circleId` of the circle in question.

This fixes the wrong `level` being set for `initiator` when calling
`circleProbe()` with `DataProbe::INITIATOR`.

Fixes: #1757

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0240df8 View commit details
    Browse the repository at this point in the history

  2. feat(CirclesManager): Add flag to enforce synchronous event execution 

    Required for testing (where only one php thread is available), but as
well for clients that require the event to be excecuted immediately.

Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    3edf4ed View commit details
    Browse the repository at this point in the history

  3. test(phpunit): Add basic phpunit integration tests for CirclesManager 

    Signed-off-by: Jonas <jonas@freesources.org>
    @mejo-
    mejo- committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8aae043 View commit details
    Browse the repository at this point in the history