Additional tests for pull requests

Fix bug #2269 #1695

Sign in to view logs

Triggered via pull request April 24, 2024 07:10

synchronize #2270

fix/2269-missing-recipe-ids

Status Success

Total duration 13m 0s

Artifacts –

pull-checks.yml

on: pull_request

Check if the changelog was updated

Check for added todo messages

Check for matching app info file

Make sure the package.json is well-formatted

Block fixup and squash commits

Annotations

5 warnings

Check for added todo messages: lib/Controller/Implementation/RecipeImplementation.php#L112

Found @todo Parameter id is never used. Fix that

Check for added todo messages: tests/Unit/Controller/Implementation/RecipeImplementationTest.php#L333

Found @todo no implementation in controller

Check for added todo messages: tests/Unit/Controller/Implementation/RecipeImplementationTest.php#L588

Found @todo Assert on image data/file name

Check for added todo messages: tests/Unit/Controller/Implementation/RecipeImplementationTest.php#L589

Found @todo Avoid business code in controller

Check for added todo messages: tests/Unit/Controller/Implementation/RecipeImplementationTest.php#L668

Found @todo no work on controller