Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add translationtool command options and check-files action #651

Conversation

smarinier
Copy link
Contributor

  • translationtool.php/phar more friendly command options handling (usage, -h, -v)
  • verbose mode displays some information (as the xgettext full command)
  • check-files generates a tmp xgettext "extract-all" strings. If some "t(x,y)" are in these strings, this may indicate that the sentence won't be treated by the standard xgettext command. Displays it as a warning.

…s action

Signed-off-by: Sebastien Marinier <seb@smarinier.net>
@smarinier
Copy link
Contributor Author

smarinier commented Aug 16, 2024

Hi @nickvergessen,

This is linked to bbb/issue#261
check-files on a multi-apps nextcloud displays many warnings. But it scans also generated minified js. So... I found only two untranslated sentences from Collabora. It works fine on backtick bug mainly (wich is quite unusual)

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks mostly good, but didn't execute it yet.

translations/translationtool/src/translationtool.php Outdated Show resolved Hide resolved
translations/translationtool/src/translationtool.php Outdated Show resolved Hide resolved
translations/translationtool/src/translationtool.php Outdated Show resolved Hide resolved
translations/translationtool/src/translationtool.php Outdated Show resolved Hide resolved
smarinier and others added 4 commits August 17, 2024 10:49
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Sébastien Marinier <seb@smarinier.net>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Sébastien Marinier <seb@smarinier.net>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Sébastien Marinier <seb@smarinier.net>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Sébastien Marinier <seb@smarinier.net>
@nickvergessen nickvergessen merged commit 93319dd into nextcloud:master Aug 26, 2024
1 check passed
@nickvergessen
Copy link
Member

Recompiled the phar in #655 after adding our coding style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants