Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Add exif description to the slideshow #114

Open
oparoz opened this issue Sep 4, 2016 · 11 comments
Open

Add exif description to the slideshow #114

oparoz opened this issue Sep 4, 2016 · 11 comments
Labels
enhancement New feature or request

Comments

@oparoz
Copy link
Member

oparoz commented Sep 4, 2016

From @oparoz on February 17, 2016 0:16

@0xb0ba has opened a PR which adds the EXIF description to an image shown in the slideshow, if it exists. There are still quite a few opened questions regarding the design.

Should the description :

  • Be centred?
  • Be spread over 3 lines?
  • Include a scroller or rollover? Rollover would fill the screen with that description since we have to keep it narrow. A scroller requires 2 additional touch areas instead of an ugly scrollbar
  • Be enabled/disabled via a button? Because it can mask the view and would not disappear when interacting with the slideshow, so, the default would be to hide the description
  • Be shown in a sliding sidebar?

Examples

Picasa

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Copied from original issue: owncloud/gallery#525

@oparoz oparoz added designer wanted enhancement New feature or request labels Sep 4, 2016
@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @0xb0ba on February 26, 2016 5:37

Be centred?

yes

Include a scroller or rollover?

nothing

Be enabled/disabled via a button?

no. autohide in 3 sec

Be shown in a sliding sidebar?

yes. all tags (all photo tags) from exif. but php exif lib is poor. exiftool?

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @Bugsbane on February 28, 2016 9:34

Be centered?

Yes

Spread over 3 lines?

Personally I would make a div with a minimum height of around 1em (ie a single line high) and a max height of a few percentage points of the screen height (I'd need to judge this visually on my desktop, and I'm on my phone now, but I can do a mock-up for precise numbers), center it horizontally and align it to the bottom of the screen with a margin of say .5 em.

I'd make the text color white with a black css dropdown shadow (this tends towards decent readability against a wide variety of backgrounds as long as the shadow outlines the text at least a little in all directions, maybe blur 3px, with no x offset and a y offset of 2px).

I'd set overflow to cut off, ideally with an opacity gradient fading the text out at the end, and an ellipses to signify more text being available, but have a tooltip display with a system standard font size with the full text on hover or click.

As Jan suggests, I'd go with fading after 3 seconds, but I'd reverse the fade-out if the text is hovered over or clicked on. Onmouseout restart the 3 second countdown.

No to buttons, scrollers, roll overs and scroll bars.

Yes to showing in the sidebar.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

Thanks for the feedback. It's interesting that both of you think the description should fade away with the rest. I can think of at least one use-case where I would want the description to show permanently: In slideshow mode in a real gallery if I wanted to add a caption to each image. So maybe there should be 2 modes, one with tooltip + fade and a permanent description one

I'd greatly appreciate some mockups.

Things to look for:

  • There should be a max width to keep the description readable. A paragraph is better than a long line
  • Both the filename and the description have to be shown
  • Some mockups should include the other buttons in the UI to be able to see how it all fits together

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @0xb0ba on February 28, 2016 15:21

serious doubts that the file name should be in full screen.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @Bugsbane on February 28, 2016 15:23

Yes, I agree on the max-width.

I question whether it's best to show both the description and the filename at
all time, especially in slideshow mode. Generally, if an actual description
has been given then it's more meaningful to the user in a slideshow mode
(which is more about casual viewing than hunting down technical details).
Personally I would suggest showing the description where one has been set, the
filename where one has not, and making the filename available in the sidebar
info for anyone looking for more than is shown in the sileshow view.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @Bugsbane on February 28, 2016 15:25

I'm happy to run up a mockup though as soon as we have a general agreement on
what should be in it, or at least that people have polarised around a couple
of options.

Yes, I agree on the max-width.

I question whether it's best to show both the description and the filename
at all time, especially in slideshow mode. Generally, if an actual description
has been given then it's more meaningful to the user in a slideshow mode
(which is more about casual viewing than hunting down technical details).
Personally I would suggest showing the description where one has been set, the
filename where one has not, and making the filename available in the sidebar
info for anyone looking for more than is shown in the sileshow view.

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

I'm happy to run up a mockup though as soon as we have a general agreement on
what should be in it, or at least that people have polarised around a couple
of options.

Makes sense

@oparoz
Copy link
Member Author

oparoz commented Sep 4, 2016

From @turb on May 24, 2016 22:35

Hello, what options still need to be agreed on, in order to merge this PR?

If the only one is "should both description and filename be displayed, or only the description", my own preference goes to only the description (filename makes little sense when the description has been filled).

@turb
Copy link

turb commented Sep 5, 2016

@oparoz agreed. As far as I see, it matches the current PR, so you can merge it ;)

This issue has been moved to Nextcloud: does it mean this app is and will be managed solely by the Nextcloud team? Will you ensure compatibility with ownCloud?

@oparoz
Copy link
Member Author

oparoz commented Sep 7, 2016

This issue has been moved to Nextcloud: does it mean this app is and will be managed solely by the Nextcloud team? Will you ensure compatibility with ownCloud?

Anybody can contribute. Developers who want to take it further can even become maintainers :)
I cannot guarantee compatibility with ownCloud, but again, anybody can provide patches to fix what breaks until it becomes obvious that both products have become too different.

@tacruc
Copy link

tacruc commented Oct 24, 2017

What is the State of the Issue or of the PR?
There is a new Feature Request #320 for the same issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants