Skip to content
This repository has been archived by the owner on Nov 1, 2020. It is now read-only.

Hide download feature not working for folders #523

Open
ravi-gh opened this issue Jun 14, 2019 · 2 comments
Open

Hide download feature not working for folders #523

ravi-gh opened this issue Jun 14, 2019 · 2 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@ravi-gh
Copy link

ravi-gh commented Jun 14, 2019

Bug report

Steps to reproduce

  1. Share a folder with images in the Files section of Nextcloud, making sure the "Hide download" checkbox is checked.
  2. Open the folder in Gallery app and copy the sharing link.
  3. Use the link to share the Gallery view with others

Expected behaviour

When somebody open the link, the "Download" buttons in gallery view and slideshow view should not be visible.

Actual behaviour

When they open the link, the "Download" buttons in both gallery view and slideshow view are visible.

Server configuration

Nextcloud configuration

Nextcloud version: Nextcloud 15.0.7, Gallery 18.2.0

Updated from an older installation or fresh install: Fresh install

Are you using custom gallery.cnf config files: no

Client configuration

Browser: Firefox 67

Operating system:
Windows 10

@ravi-gh
Copy link
Author

ravi-gh commented Jun 14, 2019

I believe the related issue of "Hide download" not working when sharing a single image was resolved in the following issue report - #484
However, the above fix does not apply when the shared item happens to be an entire folder with images. Further fixes are required for this.

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of bug Something isn't working labels Sep 3, 2019
@mstenz
Copy link

mstenz commented Sep 19, 2019

thank you for adding this bug, i am experiencing the same. Because this is a security leak please have high priority on this topic. I wanted to use gallery to share images on my website that are hosted on nextcloud but with this situation i am not able yet to make this happen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants