Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add task processing API #12

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: Add task processing API #12

merged 1 commit into from
Jul 17, 2024

Conversation

provokateurin
Copy link
Member

Still very much WIP.

@provokateurin provokateurin force-pushed the feat/task-processing branch 2 times, most recently from d4e7a60 to e285cf0 Compare June 4, 2024 11:00
provokateurin
provokateurin commented Jun 4, 2024
View reviewed changes
lib/main.py Outdated Show resolved Hide resolved
bigcat88
bigcat88 reviewed Jun 5, 2024
View reviewed changes
lib/main.py Outdated Show resolved Hide resolved
provokateurin
provokateurin commented Jun 5, 2024
View reviewed changes
lib/main.py Outdated Show resolved Hide resolved
bigcat88
bigcat88 reviewed Jun 7, 2024
View reviewed changes
lib/main.py Outdated Show resolved Hide resolved
@marcelklehr
Copy link
Member 

Exception in thread Thread-1:
Traceback (most recent call last):
  File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/home/marcel/code/llm2/lib/main.py", line 46, in run
    response = nc.providers.task_processing.next_task(list(provider_ids), list(task_type_ids))
AttributeError: 'ProvidersApi' object has no attribute 'task_processing'. Did you mean: 'text_processing'?

Is this not available in v0.13 yet?

@bigcat88
Copy link
Member

bigcat88 commented Jun 8, 2024

Is this not available in v0.13 yet?

it is availably in PR: cloud-py-api/nc_py_api#254

AppAPI PR was not merged yeat

@provokateurin
Copy link
Member Author

To test this please locally revert a16e617

@provokateurin provokateurin marked this pull request as ready for review July 8, 2024 08:57
@provokateurin
Copy link
Member Author

Still depends on cloud-py-api/nc_py_api#254, but I could finally test it correctly!

@bigcat88
Copy link
Member

bigcat88 commented Jul 9, 2024

Still depends on cloud-py-api/nc_py_api#254, but I could finally test it correctly!

nc-py-api 0.14.0 with the support of the new API was published

we can test this PR with it and free to merge this after that.

bigcat88
bigcat88 reviewed Jul 9, 2024
View reviewed changes
lib/main.py Outdated Show resolved Hide resolved
bigcat88
bigcat88 reviewed Jul 9, 2024
View reviewed changes
lib/main.py Show resolved Hide resolved
bigcat88
bigcat88 reviewed Jul 9, 2024
View reviewed changes
lib/main.py Show resolved Hide resolved
@provokateurin
feat: Add task processing API
f29f439 
Signed-off-by: provokateurin <kate@provokateurin.de>
marcelklehr
marcelklehr approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks, good. Thanks!

@marcelklehr marcelklehr merged commit 1add161 into main Jul 17, 2024
1 check passed
@marcelklehr marcelklehr deleted the feat/task-processing branch July 17, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@andrey18106 andrey18106 Awaiting requested review from andrey18106

@bigcat88 bigcat88 Awaiting requested review from bigcat88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@provokateurin @marcelklehr @bigcat88