fix: catch network exceptions and keep the loop going #22
Conversation
|
looks fine, but maybe better to do it with logging, like here?https://github.com/Visionatrix/Visionatrix/blob/f86cb154527d5ee4429468902a80c8726a880257/visionatrix/routes/tasks.py#L610-L626 |
lib/main.py
Outdated
| except Exception as e: # noqa | ||
| print(str(e), flush=True) | ||
| nc = NextcloudApp() | ||
| nc.log(LogLvl.ERROR, str(e)) | ||
| nc.providers.task_processing.report_result(task["id"], error_message=str(e)) | ||
| with suppress(Exception): | ||
| nc = NextcloudApp() | ||
| nc.log(LogLvl.ERROR, str(e)) | ||
| nc.providers.task_processing.report_result(task["id"], error_message=str(e)) |
There was a problem hiding this comment.
this should serve the purpose, no? Or did you mean with the logger module?
There was a problem hiding this comment.
I mean, sometimes it's useful to output exceptions to logs, at least to debug or "info" level - so that it would be easier to diagnose problems later.
I also like "supress", a very good thing.
There was a problem hiding this comment.
oh, yes logging there would be good. I was thinking along the lines that there was already an error that should be addressed, others were not relevant. Logging again doesn't hurt ✌️
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/catch-exceptions
branch
from
67ec0aa
to
ddea11d
Compare
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
kyteinsky
force-pushed
the
fix/catch-exceptions
branch
from
ddea11d
to
5fc7409
Compare
No description provided.