Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to disable direct-editing #1904

Merged

Conversation

newhinton
Copy link
Contributor

Implements #1819

This PR implements a toggle that changes the behaviour of the edit-fragment.

Original:
Notes-fragment has a fab that allows the user to open rich editing. In the toolbar is a pen for the local editor. The pen changes to an eye if in edit mode.

Now:
If rich text is enabled (which is the default), the ui does not change.
If it is not enabled, the fab is now a button to open the local editor. In the editor, no fab is shown, but the eye-icon as before.

@newhinton newhinton force-pushed the feature/1819/disableRichEditor branch from 371c6cf to 014609b Compare September 26, 2023 07:46
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
@AndyScherzinger AndyScherzinger force-pushed the feature/1819/disableRichEditor branch from 014609b to b9fc968 Compare April 1, 2024 12:31
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger added this to the 4.3.0 milestone Apr 1, 2024
@AndyScherzinger AndyScherzinger merged commit 9ab92fd into nextcloud:main Apr 1, 2024
12 of 13 checks passed
@AndyScherzinger
Copy link
Member

/backport to stable-4.2

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants