Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: give hint about missing server-side app for 404s #2274

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

joshtrichards
Copy link
Member

Closes #1893 (and other recurring ones)

@joshtrichards joshtrichards added this to the 4.3.1 milestone Jul 11, 2024
@joshtrichards joshtrichards marked this pull request as ready for review July 11, 2024 12:22
Copy link
Member

@stefan-niedermann stefan-niedermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why the 404 case was missing. Maybe something changed server side in the past few months about return values for not existing apps.

However, tip is perfectly fine here 👍

Closes #1893 (and other recurring ones)

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards force-pushed the jtr/fix-404-server-app-hint branch from 617bf2e to 970834e Compare July 13, 2024 20:06
@AndyScherzinger AndyScherzinger merged commit d2ea7a9 into main Jul 15, 2024
13 checks passed
@AndyScherzinger AndyScherzinger deleted the jtr/fix-404-server-app-hint branch July 15, 2024 16:20
@AndyScherzinger AndyScherzinger modified the milestones: 4.3.1, 4.4.0 Jul 15, 2024
@AndyScherzinger
Copy link
Member

/backport to stable-4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP 404: Cannot connect Nextcloud server to app
3 participants