Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mobile vertical scrolling #15462

Merged
merged 1 commit into from
May 9, 2019
Merged

Fix mobile vertical scrolling #15462

merged 1 commit into from
May 9, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 9, 2019

Fix #15233

@skjnldsv
Fix mobile vertical scrolling
d6710b5 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews high labels May 9, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16.0.1 milestone May 9, 2019
@skjnldsv skjnldsv self-assigned this May 9, 2019
@skjnldsv skjnldsv mentioned this pull request May 9, 2019
Closed
ChristophWurst
ChristophWurst approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & works 🚀

@MorrisJobke MorrisJobke mentioned this pull request May 9, 2019
Merged
@MorrisJobke
Copy link
Member

@skjnldsv Why does it update the JS assets?

@MorrisJobke
Copy link
Member

@skjnldsv Why does it update the JS assets?

Nevermind - got it.

@MorrisJobke
Copy link
Member

CSS only change -> merge

@MorrisJobke MorrisJobke merged commit c84da74 into master May 9, 2019
@MorrisJobke MorrisJobke deleted the fix/mobile/scrolling branch May 9, 2019 09:50
@MorrisJobke
Copy link
Member

/backport to stable16

@backportbot-nextcloud
Copy link

The backport to stable16 failed. Please do this backport manually.

@skjnldsv skjnldsv mentioned this pull request May 9, 2019
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented May 9, 2019

backport in #15469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.

...
3 participants
@skjnldsv @MorrisJobke @ChristophWurst