Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stable16] Fix mobile vertical scrolling #15469

Merged
merged 1 commit into from
May 9, 2019
Merged

[Stable16] Fix mobile vertical scrolling #15469

merged 1 commit into from
May 9, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented May 9, 2019

Backport of #15462

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels May 9, 2019
@skjnldsv skjnldsv added this to the Nextcloud 16.0.1 milestone May 9, 2019
@skjnldsv skjnldsv self-assigned this May 9, 2019
@skjnldsv skjnldsv mentioned this pull request May 9, 2019
Merged
@skjnldsv skjnldsv changed the base branch from master to stable16 May 9, 2019 10:28
@skjnldsv skjnldsv changed the title Stb16/fix/mobile/scrolling [Stable16] Fix mobile vertical scrolling May 9, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented May 9, 2019

For some reasons it changed some compiled files in settings 🤷‍♂️

@MorrisJobke
Copy link
Member

@skjnldsv skjnldsv changed the base branch from master to stable16 2 hours ago

This causes CI to fail :/

rullzer
rullzer approved these changes May 9, 2019
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@kesselb
Copy link
Contributor

kesselb commented May 9, 2019

Looks like the node_modules are wrong. Try npm ci and build the assets again?

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 9, 2019
@MorrisJobke
Copy link
Member

Looks like the node_modules are wrong. Try npm ci and build the assets again?

Could also that another PR didn't updated it, or am I wrong here?

@ChristophWurst
Copy link
Member

For some reasons it changed some compiled files in settings man_shrugging

Do you have node_modules inside settings? If so -> 🔥

@skjnldsv
[Stable16] Fix mobile vertical scrolling
8f56f69 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the stb16/fix/mobile/scrolling branch from 3f72d04 to 8f56f69 Compare May 9, 2019 12:19
@skjnldsv
Copy link
Member Author

skjnldsv commented May 9, 2019

Do you have node_modules inside settings? If so ->

That was it! 🎉

@MorrisJobke MorrisJobke merged commit d4bc8d3 into stable16 May 9, 2019
@MorrisJobke MorrisJobke deleted the stb16/fix/mobile/scrolling branch May 9, 2019 13:23
@MorrisJobke MorrisJobke mentioned this pull request May 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 16.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @MorrisJobke @kesselb @ChristophWurst @rullzer