Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix(files): Set download property and encode source #42314

Closed
wants to merge 1 commit into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 15, 2023

Summary

  • Fix download on trashbin files originally in a groupfolder

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 27.1.6 milestone Dec 15, 2023
@Pytal Pytal requested review from blizzz and skjnldsv December 15, 2023 19:42
@Pytal Pytal self-assigned this Dec 15, 2023
@Pytal
Copy link
Member Author

Pytal commented Dec 15, 2023

Download will trigger but the files will be 0 bytes as the URL is incorrect due to groupfolder trash being located in <data_dir>/__groupfolders/trash/

Not sure if downloading from groupfolders trash was possible before @icewind1991? If we want to allow downloads like normal files then this will need adjustments

@blizzz
Copy link
Member

blizzz commented Dec 15, 2023

Still results in a network error for me, and the download url did not really change: https://my.nc.srv/remote.php/dav/trashbin/$UID/trash/$FILENAME.$EXT.d1675427849

@Pytal
Copy link
Member Author

Pytal commented Dec 15, 2023

Still results in a network error for me, and the download url did not really change: https://my.nc.srv/remote.php/dav/trashbin/$UID/trash/$FILENAME.$EXT.d1675427849

Tried after compile?
URL not changed in this PR, only the download property is set which should trigger the 0 byte download

Will need to know from @icewind1991 how groupfolder trash downloads worked before

@blizzz
Copy link
Member

blizzz commented Dec 15, 2023

Still results in a network error for me, and the download url did not really change: https://my.nc.srv/remote.php/dav/trashbin/$UID/trash/$FILENAME.$EXT.d1675427849

Tried after compile? URL not changed in this PR, only the download property is set which should trigger the 0 byte download

… and hard reload, yes. Even twice for good measure ;)

@Pytal
Copy link
Member Author

Pytal commented Jan 4, 2024

Superseded by nextcloud/groupfolders#2716

@Pytal Pytal closed this Jan 4, 2024
@Pytal Pytal deleted the fix/groupfolder-trashbin-download branch January 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants