Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOS breaks PicoCMS #274

Open
codejp3 opened this issue Dec 11, 2019 · 7 comments
Open

TOS breaks PicoCMS #274

codejp3 opened this issue Dec 11, 2019 · 7 comments

Comments

@codejp3
Copy link

codejp3 commented Dec 11, 2019

"Call to undefined method ParsedownExtra::textElements()" in PicoCMS with TOS enabled.

Please reference the thread on PicoCMS about this issue.

nextcloud/cms_pico#97

@rollanders
Copy link

rollanders commented Jan 31, 2020

@nickvergessen @PhrozenByte I will lift this issue as important to solve. I want both social login and PicoCMS
Is Parsedown necessary for TOS?

@nickvergessen
Copy link
Member

Is Parsedown necessary for TOS?

We use it to be able to use markdown in your terms of service, so yes kind of.

@ChristophWurst
Copy link
Member

@PhrozenByte
Copy link

@ChristophWurst Subscribed to your issue for updates. Since it's an ecosystem issue, are we going to see this being officially supported by Nextcloud? IMO it would be a good thing to give @coenjacobs some support (and some visibility) by Nextcloud, as it looks like he's doing this on his own... It's neither just Guzzle nor Parsedown, it's kind of a miracle that these kind of conflicts don't happen more often...

@nickvergessen
Copy link
Member

Well every app can/should do this when it has such problems. It's nothing Nextcloud can fix for all app maintainers

@PhrozenByte
Copy link

@nickvergessen It's all about recommendations and documentation 😉

@ChristophWurst
Copy link
Member

I want to explore these tools a bit more. If they can be used reliably, we can add them to our docs.

While it currently doesn't help with Guzzle conflicts, it could work with parsedown. You may look at my PR and just try to apply it here. Then check if the app still works :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants