Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hooks instead of stack trace inspection #498

Open
4 tasks
PVince81 opened this issue Mar 18, 2021 · 2 comments
Open
4 tasks

Use hooks instead of stack trace inspection #498

PVince81 opened this issue Mar 18, 2021 · 2 comments

Comments

@PVince81
Copy link
Member

Instead of inspecting the stack trace in

$trace = $exception->getTrace();
, introduce (cancellable?) hooks in relevant classes in server.

The hooks could be called something like "beforeCopySkeleton" and "afterCopySkeleton"

  • LoginController
  • ClientFlowLoginController
  • ClientFlowLoginV2Controller
  • RegisterController
@nickvergessen
Copy link
Member

nickvergessen commented Mar 18, 2021

But this is not only about the skeleton. it's also when doing the skeleton.
But also e.g. when talk tries to create the Talk folder on login, etc (exactly the problem that led to #496 )

@PVince81
Copy link
Member Author

ah yes, so probably will need to rename the function also.
it's about the various login flows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants