Skip to content

Commit

Permalink
Add warning for plaintext passwords, set default password mode to secure
Browse files Browse the repository at this point in the history
Signed-off-by: Sebastian Sterk <sebastian@wiuwiu.de>
  • Loading branch information
sebastiansterk committed Aug 1, 2019
1 parent 66747db commit 5dc9b1d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ Add the following to your `config.php`:
2 => 'dbuser',
3 => 'dbuserpassword',
4 => 'xmppdomain',
5 => true,
5 => true,
),
),
),
Expand All @@ -207,6 +207,9 @@ Add the following to your `config.php`:
4 - XMPP Domain
5 - Hashed Passwords in Database (true) / Plaintext Passwords in Database (false)

**⚠⚠ Warning:** If you need to set *5 (Hashed Password in Database)* to false, your Prosody Instance is storing passwords in plaintext. This is insecure and not recommended. We highly recommend that you change your Prosody configuration to protect the passwords of your Prosody users. ⚠⚠


Alternatives
------------
Other extensions allow connecting to external user databases directly via SQL, which may be faster:
Expand Down
2 changes: 1 addition & 1 deletion lib/xmpp.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class OC_User_XMPP extends \OCA\user_external\Base {
private $xmppDomain;
private $passwordHashed;

public function __construct($host, $xmppDb, $xmppDbUser, $xmppDbPassword, $xmppDomain, $passwordHashed) {
public function __construct($host, $xmppDb, $xmppDbUser, $xmppDbPassword, $xmppDomain, $passwordHashed = true) {
parent::__construct($host);
$this->host = $host;
$this->xmppDb = $xmppDb;
Expand Down

0 comments on commit 5dc9b1d

Please sign in to comment.