Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add vitest and some basic integration tests #146

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Sep 13, 2024

Add vitest as test framework and some rather basic integration tests for the metrics endpoint and socket auth.

npm install --save axios
npm install --save-dev vitest

@juliushaertl
Copy link
Member Author

🏓 for review ... will resolve the package.json conflict before merge to avoid another conflict.

Copy link

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one minor question.

websocket_server/SocketManager.js Show resolved Hide resolved
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliushaertl juliushaertl merged commit 15fecb1 into main Oct 7, 2024
27 checks passed
@juliushaertl juliushaertl deleted the vitest branch October 7, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants