Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support translation #200

Merged
merged 3 commits into from
Oct 8, 2024
Merged

support translation #200

merged 3 commits into from
Oct 8, 2024

Conversation

hweihwang
Copy link
Contributor

No description provided.

@hweihwang
support translation
3e50a13 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang hweihwang linked an issue Oct 2, 2024 that may be closed by this pull request
Translations support #50
Closed
@hweihwang
support translation
df8f441 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
grnd-alt
grnd-alt requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the feature. It looks like the getLanguage function does not return the correct string. I've set the nc language to Spanish and still got English as the language. Setting it to Russian leads to whiteboard being in Romanian.

@hweihwang
fix lang mapper
5cf3b9c 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
@hweihwang
Copy link
Contributor Author

Thank you @grnd-alt , my bad, got fixed!

@juliushaertl juliushaertl merged commit 9fdbd14 into main Oct 8, 2024
23 checks passed
@juliushaertl juliushaertl deleted the feat/support-translation branch October 8, 2024 16:56
@juliushaertl juliushaertl added the bug Something isn't working label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grnd-alt grnd-alt grnd-alt approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl juliushaertl is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Translations support
3 participants
@hweihwang @grnd-alt @juliushaertl