Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keybindings more Windows/Linux sensible #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

coconutpalm
Copy link

Ctrl+left/right moves by word on Win/Lin. This fixes the Windows/Linux keybindings to respect this.

Also, Shift+Alt+up/down grows/shrinks the selection in Eclipse and the prior default was so close to this I thought it worth making it the same for people who already have this muscle-memory.

@mk
Copy link
Member

mk commented Oct 25, 2021

Thanks for the PR! I think the wordwise movement makes sense but since im on macOS I can't really say. @leahneukirchen could you chime in here?

Making grow/shrink selection more like Eclipse is something I feel less good about as it complicates the shortcut and I'm not sure how many Clojurians use Eclipse. You're the first one I hear about Clojure + Eclipse from.

@coconutpalm
Copy link
Author

Thanks for the PR! I think the wordwise movement makes sense but since im on macOS I can't really say. @leahneukirchen could you chime in here?

Thanks!

Making grow/shrink selection more like Eclipse is something I feel less good about as it complicates the shortcut and I'm not sure how many Clojurians use Eclipse. You're the first one I hear about Clojure + Eclipse from.

I'm okay with other alternatives, but if we're already close to Eclipse's implementation it makes sense to me just to use that--to avoid confusion for those with Eclipse muscle-memory.

@leahneukirchen
Copy link

Ctrl+Left/Right is indeed used by default in Gtk, Emacs, Vim.

@Sohalt
Copy link

Sohalt commented Jul 6, 2022

Ctrl+left/right for movement makes sense to me.
I don't have any strong opinions about the keybinding for growing/shrinking the selection. I don't think Eclipse is a good reason for changing the keybindings, though one could argue that it makes sense to add Shift as a modifier, because you adjust the selection (which is usually done using shift+movement).

@zampino zampino changed the base branch from master to main July 6, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants