Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfigOutput is not behaving as expected or hoped #215

Closed
timspainNERSC opened this issue Jan 16, 2023 · 3 comments · Fixed by #383
Closed

ConfigOutput is not behaving as expected or hoped #215

timspainNERSC opened this issue Jan 16, 2023 · 3 comments · Fixed by #383
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@timspainNERSC
Copy link
Collaborator

  1. The logged output times are not the true output times
  2. Given a model start time and output start time of 00:00 the first output occurs at 00:10, i.e. after 1 model timestep. It then recurs with the correct frequency. If the desired frequency is once per hour, output occurs at 00:10, 01:10, 02:10 &c.
  3. The infrastructure now exists (in ParaGridIO) to output more than one time sample into a file. When ConfigOutput is being used it should be able to assume that this is possible and not generate a new file at each output time.
  4. The output frequency and the frequency of opening new IO files should both be separate and specifiable.
@timspainNERSC timspainNERSC added bug Something isn't working enhancement New feature or request labels Jan 16, 2023
@timspainNERSC timspainNERSC added this to the 2 Functional tests milestone Jan 16, 2023
@timspainNERSC timspainNERSC self-assigned this Jan 16, 2023
@timspainNERSC
Copy link
Collaborator Author

Item 1 ✅
Item 2: Output only happens when the end of a timestep exactly equals an integer multiple of the time since the last output. That is, starting at midnight and requesting output every hour will only output when the end of a timestep exactly coincides with an hour. Eleven minute timesteps and hourly output would only output at 11:00, 22:00 etc. So, ✅
Item 3 ✅

@timspainNERSC timspainNERSC moved this from Todo to In Progress in neXtSIM_DG overview Jan 19, 2023
@timspainNERSC
Copy link
Collaborator Author

The code to fix this is present in the branch jun23_demo and its descendants.

@timspainNERSC timspainNERSC linked a pull request Sep 8, 2023 that will close this issue
timspainNERSC added a commit that referenced this issue Oct 30, 2023
# ConfigOutput enhancements
## Fixes \#215

---

# Change Description

* Correct the output times of ConfigOutput.
* Reuse files for multiple output instances, rather than creating a new
file each time.

---

# Test Description

The test ConfigOutput_test tests this class.

~This test shall remain a draft until PR #373 is merged into develop.~
timspainNERSC added a commit that referenced this issue Oct 30, 2023
# ConfigOutput fixes
## Fixes \#215

Cherry pick commits ae32264, 7906942, 4de461a back onto `develop`. But
these were already in `issue215_configoutput`?

This will fix the CI again.
@timspainNERSC
Copy link
Collaborator Author

With #383 and #428 merged into develop, this issue is fixed.

@github-project-automation github-project-automation bot moved this from In Progress to Done in neXtSIM_DG overview Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

1 participant