Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail for devgrid in the rect10x10 test case #433

Closed
MarionBWeinzierl opened this issue Nov 10, 2023 · 2 comments
Closed

Fail for devgrid in the rect10x10 test case #433

MarionBWeinzierl opened this issue Nov 10, 2023 · 2 comments
Labels
bug Something isn't working ICCS Tasks or reviews for the ICCS team
Milestone
2 Integration tests

Comments

@MarionBWeinzierl
Copy link
Contributor

MarionBWeinzierl commented Nov 10, 2023 •
edited
Loading

When running run_rect10x10.sh I get the following error:

 terminate called after throwing an instance of 'netCDF::exceptions::NcHdfErr'
   what():  NetCDF: HDF error
 file: ncVar.cpp  line:795
 Aborted (core dumped)

This error does not occur, for example, for run_simple_example.sh or run_rect20x30.sh. Inspecting the respective .nc files shows that the 10x10 case uses the group attribute type devgrid, while the others use metagrp.type = "simple_rectangular" or "parametric_rectangular".

I changed the type from devgrid to simple_rectangular for 10x10 in #331 . However, it needs further investigation into the devgrid implementation to find out where the problem lies and whether it can be fixed, and/or devgrid can be abandoned and removed from the codebase, falling to simple_rectangular for the cases where we would have used it.

This decision will impact #292 .
@MarionBWeinzierl MarionBWeinzierl added bug Something isn't working ICCS Tasks or reviews for the ICCS team labels Nov 10, 2023
@MarionBWeinzierl MarionBWeinzierl added this to the 2 Integration tests milestone Nov 10, 2023
@MarionBWeinzierl
Copy link
Contributor Author

@timspainNERSC and @einola have confirmed that devgrid, its tests, and also the run_rect10x10 example can be removed from the repository.

@MarionBWeinzierl MarionBWeinzierl moved this from Todo to Pending in neXtSIM_DG overview Nov 14, 2023
@MarionBWeinzierl MarionBWeinzierl moved this from Pending to In Progress in neXtSIM_DG overview Nov 14, 2023
@MarionBWeinzierl MarionBWeinzierl mentioned this issue Nov 14, 2023
Merged
4 tasks
MarionBWeinzierl added a commit that referenced this issue Nov 15, 2023
@MarionBWeinzierl
Remove devgrid files and usage (#437)
eea83a6 
# Remove DevGrid and associated tests
## Fixes #433

### Task List
- [x] Remove files for DevGrid, DevGrid IO and associated tests
- [x] Adapt code and remove any usage or mention of DevGrid
- [x] Remove the `rect10x10` test
- [x] Make sure I haven't broken anything and all the tests run through

---
# Change Description
The DevGrid functionality is no longer needed, as it can be fullfilled
by the `RectangularGrid` or `ParametricGrid`. Therefore it was removed
from the code base, and the tests and cmake lists adapted accordingly.
@MarionBWeinzierl
Copy link
Contributor Author

Fixed in #437

@github-project-automation github-project-automation bot moved this from In Progress to Done in neXtSIM_DG overview Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ICCS Tasks or reviews for the ICCS team
Projects
neXtSIM_DG overview
Status: Done
Milestone
2 Integration tests
Development

No branches or pull requests
1 participant
@MarionBWeinzierl