-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XIOS Integration (MVP) #265
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
CMake progress is good but needs some tidying. E.g. Proof of concept build is working. |
This was referenced Sep 18, 2023
4 tasks
…unication, presume xios was anticipating further setup)
…it round but not necessary to proceed.
…es appropriately (ifcore already available, don't search)
nextsim build fails due to incorrect order of libraries -lxios needs to come before -lnetcdf also for gnu compiler we need -lgfortran and for intel compiler we need -lifcore TODO: Findxios in conjuction with the CMakeLists.txt needs fixing still so that it can work when xios is not installed.
I have manually changed lib ifcore to lgfortran. This will need to fixed properly for intel and gnu compiler and not hard-coded. this is a temporary fix. The order of libs is also incorrect for XIOS_LIBRARY_LIST. xios depends on netcdf so it should come second. There was an erroneous ::Xios for the constructor when creating xios_handler.
I have updated the ubuntu install and setup for XIOS and nextsimdg I have removed unnecessary packages and hopefully xios will now build.
TomMelt
force-pushed
the
feature218_xios_io
branch
from
October 4, 2023 16:16
bc18177
to
91cf839
Compare
This was referenced Oct 5, 2023
Closed
I have updated and simplified the Xios class We have methods to get/set common variables: * Calendar origin * Calendar start * Calendar timestep There are some initialization method and an isInitialized function to verify. I have simplified the string conversion string for datetime
this PR has got stale due to significant changes since the beginning of XIOS project. This PR will be superseded by #496 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextsim XIOS Integration
Closes #218
This is a master pull request tracking the integration of XIOS for File I/O into Nextsim DG. Some of the sub-components are being tracked by separate PRs. See the design document on the Wiki for more information on XIOS Integration.
The core functionality of XIOS is included as part of this PR as the other two components will require it.
Core XIOS functionality
Closes #293
XIOS uses a client-server model. To use XIOS we must first initialize the clients on each process (
cxios_init_client
) and subsequently initialize the server (cxios_context_initialize
). Here are the necessary steps to be able to setup the XIOS client & server processes.CMakeLists.txt
mpi_local
) (I am dependent ondoctest
with MPI support)doctest
NOTE currently addressing bug in Xios class that affects the
getCalendarTimestep
method. For now I have implemented a work around (I have now fixed this with #424 but I want to find a better solution for mpi-aware doctests).Once the essentials have been created to begin using XIOS my intention is for the development branches to be structured as follows:
Merge instructions
When development of all XIOS features is ready (#422, #421 and this PR). The plan is to merge them (in reverse order) into this branch, finally merging this branch back into
feat_mar3
feat_mar3
feature218_xios_io
- XIOS Integration (MVP) #265xios-nextsim-data-io
- XIOS Nextsim Data IO #422xios-nextsim-sync-data
- XIOS Nextsim data synchronization #421Notes on XIOS
XIOS
is a third party library which was designed to handle file I/O asynchronouslyXIOS
requires a configuration.xml
file defining a calendar system to run.xml
or at runtime (see UserGuide for more info)