Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue215 configoutput #383

Merged
merged 51 commits into from
Oct 30, 2023
Merged

Issue215 configoutput #383

merged 51 commits into from
Oct 30, 2023

Conversation

timspainNERSC
Copy link
Collaborator

@timspainNERSC timspainNERSC commented Sep 8, 2023 •
edited
Loading

ConfigOutput enhancements

Fixes #215

Change Description

  • Correct the output times of ConfigOutput.
  • Reuse files for multiple output instances, rather than creating a new file each time.

Test Description

The test ConfigOutput_test tests this class.

This test shall remain a draft until PR #373 is merged into develop.

timspainNERSC and others added 30 commits May 11, 2023 10:14
@timspainNERSC
Add ConfigOutput to the command line help text.
d01236f
@timspainNERSC
Add config keys for file name and period.
64884b8
@timspainNERSC
Add the simple diagnostic file name configuration.
b5436ff
@timspainNERSC
Allow a strformat string to be used in TimePoint::format.
e8f55c3
@timspainNERSC
Periodic ConfigOutput diagnostic files that compile.
1f229e9
@timspainNERSC
Add help text for the periodic diagnostic file configuration.
cc2ea71
@timspainNERSC
Correct spelling of put_time().
b053713
@timspainNERSC
Add a test for ConfigOutput.
049b2dd
@timspainNERSC
Refactor the output time logic.
da125e6
@timspainNERSC
Get the ConfigOutput test to output something.
696d838
@timspainNERSC
Add a class that provides a callback mechanism to close files.
5ab6691
@timspainNERSC
Add the FileCallbackCloser to ParaGridIO.
4312698
@timspainNERSC
Close files with ConfigOutput.
90aa68f
@timspainNERSC
Test ConfigOutput.
f7bb88a
@timspainNERSC
Swap indexing in ModelArray and its test.
e36d499
@timspainNERSC
Fix zIndexAndLayer for the swapped array ordering.
43bd272
@timspainNERSC
Add a test of zIndexAndLayer.
a794191
@timspainNERSC
Add a three-dimensional test ModelArray type.
e830625
@timspainNERSC
Update the 10x10 restart file and script to use swapped array indices.
0513329
@timspainNERSC
Update the 30x30 restart file and script to use swapped array indices.
c383bee
@timspainNERSC
Regenerate the 20x30 init file, along with a new generation script.
dd25209
@timspainNERSC
Remove commented code.
3c5731d
@timspainNERSC
Make ParaGridIO compatible with reversed array index ordering.
d95119f
@timspainNERSC
Only reverse the array dimensions once.
237801f
@timspainNERSC
Correct the ERA5 test for the swapped array ordering.
16cae3b
@timspainNERSC
Correct the TOPAZ test for the swapped array ordering.
ecb65f4
@timspainNERSC
Merge branch 'develop' into issue275_2_arrayordering
c6a89a6
@timspainNERSC
Add explanatory comments to tests and expand names.
9cf019d
@timspainNERSC
Test the array ordering in ParaGridIO by reading from a netCDF.
ee5ba90
@timspainNERSC
Swap x and y in the forcing test file.
733e54c
@timspainNERSC timspainNERSC added bug Something isn't working enhancement New feature or request labels Sep 8, 2023
@timspainNERSC timspainNERSC added this to the 2 Functional tests milestone Sep 8, 2023
@timspainNERSC timspainNERSC self-assigned this Sep 8, 2023
@timspainNERSC timspainNERSC linked an issue Sep 8, 2023 that may be closed by this pull request
ConfigOutput is not behaving as expected or hoped #215
Closed
@timspainNERSC timspainNERSC changed the title Issue215 configoutput WIP: Issue215 configoutput Sep 11, 2023
@timspainNERSC timspainNERSC mentioned this pull request Sep 11, 2023
Merged
timspainNERSC added a commit that referenced this pull request Sep 11, 2023
@timspainNERSC
Issue 215 into develop working branch (#384)
e145cdd 
Merge the issue 215 branch into `develop+373` working branch. Shadows PR
#383
@timspainNERSC timspainNERSC mentioned this pull request Oct 27, 2023
Merged
@MarionBWeinzierl MarionBWeinzierl mentioned this pull request Oct 27, 2023
Merged
@timspainNERSC timspainNERSC changed the title WIP: Issue215 configoutput Issue215 configoutput Oct 27, 2023
@timspainNERSC timspainNERSC marked this pull request as ready for review October 27, 2023 12:53
@timspainNERSC timspainNERSC mentioned this pull request Oct 27, 2023
Merged
MarionBWeinzierl
MarionBWeinzierl approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@MarionBWeinzierl MarionBWeinzierl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timspainNERSC went through the changes with me explaining them, and they make sense to me.

@timspainNERSC timspainNERSC merged commit 8ed81ee into develop Oct 30, 2023
3 checks passed
@timspainNERSC timspainNERSC mentioned this pull request Nov 1, 2023
Closed
@TomMelt TomMelt deleted the issue215_configoutput branch November 1, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarionBWeinzierl MarionBWeinzierl MarionBWeinzierl approved these changes

@TomMelt TomMelt Awaiting requested review from TomMelt

Assignees

@timspainNERSC timspainNERSC

Labels
bug Something isn't working enhancement New feature or request
Projects
neXtSIM_DG overview
Status: Done
Milestone
2 Integration tests
Development

Successfully merging this pull request may close these issues.

ConfigOutput is not behaving as expected or hoped
2 participants
@timspainNERSC @MarionBWeinzierl