WIP: Issue379 netCDF generator #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The setData function didn't set qio, but neither did updateBefore, so qio was left uninitialised, causing unexpected behaviour.
I had some problems understanding the results, so I went through this with a fine-toothed comb. It's fine in the end (I'm just using too long time steps) - but I found that adding a bunch of 'const' helps to make sure. Also, found a bug where the ice temperature is set in K, and not C when everything melts (not sure if it matters, but it gave surprising results).
They specify a linear increase of a given number of cm over three different periods.
Specifically, I've renamed MonthlyFluxes to MU71Atmosphere and MonthlyIceAlbedo to MU71Albedo. These names better reflect what the functions do.
Here I fix the implementation of the zero layer model to follow Semtner's original formulation in modifying the albedo using the extinction coefficient I0. This fixes the original formulation in neXtSIM which was lacking in this respect. This commit also includes some minor bug fixes. Everything seems to work fine now.
Following M&U '71 and others, I've implemented a spline lookup using boost instead of the linear lookup I had before. The results are visibly much smoother, and compare better with the literature results (in that respect. Some other minor changes.
A longer time step and a nicer figure of the ice and snow thickness.
Consists of adding doxygen-friendly comments, where they were missing.
Consists of adding entries to ``getHelpRecursive`` of ``IAtmosphereBoundary`` (``AtmosphereBoundaryModule.cpp``). Question if we should format the help text to wrap lines?
Conflicts: run/make_init25kmNH.py
Conflicts: physics/src/modules/include/BasicIceOceanHeatFlux.hpp
Add ice corrections to the gathering branch
Merge the better dynamics into the gathering branch.
Merge the better thermo into the gathering branch.
Merge thermo demo into the gathering branch.
|
Almost all of the netCDF files have been removed from the repository, so this PR has been fulfilled elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
netCDF file generation
Fixes #379
Change Description
To avoid cluttering the repo with binary netCDF files (as far as possible), generate those files that can be generated from python scripts. This involves adding custom targets and commands to the
CMakeLists.txtfiles to run python on the necessary scripts.Test Description
Since the ERA5 and TOPAZ tests depend on some of these netCDF files, if these tests both continue to pass without file not found errors, then the changes relating to this issue can be considered to pass testing.