Issue425 Example runs should run #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was also a failing unit test, now fixed. But the other example |
MarionBWeinzierl
approved these changes
Oct 27, 2023
TomMelt
added a commit
that referenced
this pull request
Dec 4, 2023
# Add Tests for MPI version of code ### Task List - [x] add tests - [x] rebase to develop - [x] fix array ordering - [x] ~update the readthedocs / readme with install instructions~ (moved to #455) --- # Change Description I rebased @draenog's `mpi_local` and `mpi_local_tests` branches. This introduced a bug due to array reordering that occurred as part of #426. I have modified the MPI parts of `./core/src/RectGridIO.cpp` to reorder array so that they now match the order in the serial version of the code. --- # Test Description To run `testRectGrid_MPI` you will need the parallel netcdf config file `partition_metadata_1.nc`. I don't want to put it in the github repo for now. As discussed with @timspainNERSC , soon we will hopefully have an ftp server for netcdf files. You can generate the input using the following netcdf definition file `partition_metadata_1.cdl`. ``` // partition_metadata_1.cdl netcdf partition_metadata_1 { dimensions: P = 1 ; L = 1 ; globalX = 25 ; globalY = 15 ; group: bounding_boxes { variables: int global_x(P) ; int global_y(P) ; int local_extent_x(P) ; int local_extent_y(P) ; data: global_x = 0 ; global_y = 0 ; local_extent_x = 25 ; local_extent_y = 15 ; } // group bounding_boxes } ``` Then use `ncgen` to make the netcdf file `partition_metadata_1.nc` ``` ncgen partition_metadata_1.cdl -o partition_metadata_1.nc ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example runs should run
Fixes #425
Change Description
Fixes the example runs launched from
run_simple_example.shandrun_topaz128x128.shso that they run and do not crash, at least not until the end of the run.Test Description
The runs now execute mostly successfully.