Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: XIOS implementation of ParaGridIO #667

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Aug 27, 2024

XIOS implementation of ParaGridIO

Fixes #552

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

Reimplementation of the ParaGridIO class using XIOS for I/O. It will automatically be used if nextSIM-DG is compiled with XIOS enabled.

The read and write methods formerly in the Xios handler class are moved to the XIOS implementation of ParaGridIO. This is because ModelArray is going to get XIOS-related functionality and we need to avoid circular dependencies.


Test Description

...


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

Copy link
Contributor Author

@jwallwork23 jwallwork23 Sep 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion from @timspainNERSC: instead of moving the read and write methods from Xios to ParaGridIO_Xios, it might be sufficient to just forward-define the ModelArray class in Xios.

@jwallwork23 jwallwork23 self-assigned this Oct 31, 2024
@jwallwork23 jwallwork23 added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ICCS Tasks or reviews for the ICCS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reimplement ParaGridIO using XIOS
1 participant