-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: XIOS implementation of ParaGridIO
#667
Draft
jwallwork23
wants to merge
25
commits into
develop
Choose a base branch
from
issue552_xios-paragrid-io
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
commented
Sep 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion from @timspainNERSC: instead of moving the read and write methods from Xios
to ParaGridIO_Xios
, it might be sufficient to just forward-define the ModelArray
class in Xios
.
jwallwork23
force-pushed
the
issue552_xios-paragrid-io
branch
from
October 31, 2024 10:55
493b1a9
to
52bb256
Compare
jwallwork23
added
enhancement
New feature or request
ICCS
Tasks or reviews for the ICCS team
labels
Oct 31, 2024
jwallwork23
force-pushed
the
issue552_xios-paragrid-io
branch
from
November 1, 2024 14:55
4764a8e
to
fae39fc
Compare
jwallwork23
force-pushed
the
issue552_xios-paragrid-io
branch
from
November 12, 2024 10:35
49f457d
to
005b0a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XIOS implementation of
ParaGridIO
Fixes #552
Task List
Change Description
Reimplementation of the
ParaGridIO
class using XIOS for I/O. It will automatically be used if nextSIM-DG is compiled with XIOS enabled.The
read
andwrite
methods formerly in theXios
handler class are moved to the XIOS implementation ofParaGridIO
. This is becauseModelArray
is going to get XIOS-related functionality and we need to avoid circular dependencies.Test Description
...
Pre-Request Checklist