Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for XIOS install and Docker build #729

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Nov 4, 2024

Closes #719.

Apparently it has been recommended to use forge.ipsl.fr rather than forge.ipsl.jussieu.fr since March.

This PR also takes a neater approach to checking for changes in the periodic Docker build workflow.

@jwallwork23 jwallwork23 added bug Something isn't working ICCS Tasks or reviews for the ICCS team labels Nov 4, 2024
@jwallwork23 jwallwork23 self-assigned this Nov 4, 2024
@jwallwork23 jwallwork23 marked this pull request as ready for review November 4, 2024 12:26
Copy link
Contributor

@TomMelt TomMelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwallwork23 . Looks great to me

Comment on lines +6 to +10
paths:
- .github/workflows/docker.yml
- Dockerfiles/Dockerfile.devenv
- Dockerfiles/install-xios.sh
- Dockerfiles/spack_devenv.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really neat. I will try to remember this for future reference 👍

@TomMelt TomMelt merged commit 3288d6c into develop Nov 7, 2024
5 checks passed
@TomMelt TomMelt deleted the issue719_docker-fixes branch November 7, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ICCS Tasks or reviews for the ICCS team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL error in periodic Docker build
2 participants