Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue726 rheo options #730

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Issue726 rheo options #730

wants to merge 7 commits into from

Conversation

einola
Copy link
Member

@einola einola commented Nov 9, 2024

Pull Request Title

Fixes #(your issue number)

Task List

  • Defined the tests that specify a complete and functioning change (It may help to create a design specification & test specification)
  • Implemented the source code change that satisfies the tests
  • Documented the feature by providing worked example
  • Updated the README or other documentation
  • Completed the pre-Request checklist below

Change Description

Please write a summary of the change and specify which Issue this fixes. This should cover the motivation for making the change and provide almost enough context to review the change in isolation. While the issue description is a good place to discuss the failure/requirements, this is the ideal space for explaining why this design fixes the issue and why you designed it the way you did.

  • If there are important design decisions, particularly those that leverage functionality outside this change or were caused by existing limitations, they should be noted here.
  • If there is a design specification which relates to this PR, please provide a link to it here.
  • If the PR relates to an open issue, please link the issue to the PR by using the 'fixes #issue_number' syntax.
  • If the PR relates to several open issue, make sure to use 'fixes #issue_1, fixes #issue_2, etc.' syntax.
  • If there are any dependencies (third-party or internal downstream) which are added or impacted, please note them here. And if their limitations informed your design, please note how they did so here (particularly if this information was not captured in a design specification).

Text goes here


Test Description

Please describe the tests you have written that verify the enhancement works or that the bug fix has been remedied. For a bug fix, please ensure a complete description of the failure is available here or in the issue such that a reviewer can verify that the testing is suitable. This is a good place to highlight any manual testing you may have had to perform.

Please describe any operating system limitations placed on the testing (if appropriate).

If your tests fixes any issue, please explain that in the comment you provided in the test file by referencing the issue within the comment and please record the mapping here e.g.

  • testA fixes issue 404
  • testB fixes issue 999

Text goes here


Documentation Impact

Please describe any changes to the documentation not captured above or, if made in a seperate pull request, please link to the corresponding PR or issue.

Text goes here


Other Details

If you have run any static analysis, including complexity analysis, or run coverage testing which has not been captured by an automated tool, please link or copy it here.

Text goes here


Pre-Request Checklist

  • The requirements of this pull request are fully captured in an issue or design specification and are linked and summarised in the description of this PR
  • No new warnings are generated
  • The documentation has been updated (or an issue has been created to track the corresponding change)
  • Methods and Tests are commented such that they can be understood without having to obtain additional context
  • This PR/Issue is labelled as a bug/feature/enhancement/breaking change
  • File dates have been updated to reflect modification date
  • This change conforms to the conventions described in the README

Please complete your pull request description and delete the instructional text before submitting.

Congratulations and thank you for making your contribution to neXtSIM_DG!

Rename MEB to BBM, use default initialisation, and remove some unused
variables.
Start by putting it in VPParameters.hpp and MEVPStressUpdateStep.hpp.
Making it an actual option comes later.
This will be used later on for reading in from a config file.
Everything works as it should, except that it doesn't print out the
help.
@einola einola marked this pull request as draft November 9, 2024 07:06
Everything works as it should, except that it doesn't print out the
help.
Everything works as it should, except that it doesn't print out the
help.
But I'm not sure how to best configure those. In the baseclass or in the
 derived classes?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant