Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix api version param name #263

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix api version param name #263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nextcore/http/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@

await self._handle_response_error(route, response, rate_limit_storage)

raise RateLimitingFailedError(self.max_retries, response) # pyright: ignore [reportUnboundVariable]

Check failure on line 318 in nextcore/http/client/client.py

View workflow job for this annotation

GitHub Actions / pyright 

"response" is possibly unbound

async def _handle_response_error(self, route: Route, response: ClientResponse, storage: RateLimitStorage) -> None:
if response.status == 429:
Expand Down Expand Up @@ -429,7 +429,7 @@
# These have different behaviour when not provided and set to None.
# This only adds them if they are provided (not Undefined)
if version is not UNDEFINED:
params["version"] = version
params["v"] = version
if encoding is not UNDEFINED:
params["encoding"] = encoding
if compress is not UNDEFINED:
Expand Down
Loading