Use gisaid_epi_isl in workflows
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following 2e8211d, the column `isolate_id` has been renamed to `gisaid_epi_isl`.
Including the `gisaid_epi_isl` as a metadata column so it can be included in acknowledgements.
Following up on @huddlej's comment <#138 (comment)> Instead of using the accessions as colorings to force their inclusion in the build, just include them as `metadata_columns`.
3 tasks
|
This is ready for review. Once today's upload workflow runs and the |
genehack
approved these changes
Oct 10, 2024
j23414
approved these changes
Oct 14, 2024
huddlej
approved these changes
Oct 15, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR depends on #179 to be merged and run to update the metadata TSV columns on S3.
Main purpose of this PR is to Include
gisaid_epi_islas a metadata column in builds so that they can be downloaded as part of acknowledgements.Major changes
accession_haandaccession_nainstead ofAccession (HA)andAccession (NA)GISAID EPI ISLis added to the tip modal with the Auspice generated link to GISAID acknowledgements JSONgisaid_epi_islis added to the acknowledgements downloadRelated issue(s)
Resolves #178
Checklist