Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine proposed subclades in Nextclade datasets #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Oct 28, 2024

Description of proposed changes

  • Adds a 6B.1A.4 strain to list of strains to be force included in the Nextclade datasets for H1 HA trees.
  • Renames proposed_clade to proposed_subclade to clarify that the values are consistent with the newer subclades. Uses the underscore delimiter to be consistent with most other annotations in the flu builds (e.g., num_date, ne_star, submitting_lab, etc.).

Related issue(s)

Related to b09a501
Required for nextstrain/nextclade_data#236
Required for #193

Checklist

  • Checks pass

Adds a 6B.1A.4 strain to list of strains to be force included in the
Nextclade datasets for H1 HA trees.
Renames proposed subclade field to refer to subclades instead of clades
and avoid potential confusion between the older "clade" names and the
newer "subclade" names.

Uses the underscore delimiter to remain consistent with other
annotations in flu builds like `num_date`, `ne_star`, `submitting_lab`,
etc.).
@huddlej huddlej marked this pull request as ready for review October 28, 2024 18:18
@huddlej huddlej requested a review from rneher October 28, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant