Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - 1.1.0 #45

Merged
merged 127 commits into from
Nov 8, 2024
Merged

Release - 1.1.0 #45

merged 127 commits into from
Nov 8, 2024

Conversation

jannikseidelQBiC
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/detaxizer branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This PR was made against the master branch to release version 1.1.0 of detaxizer. Changes see below.

PR 33 - Bugfix in parse_kraken2report.nf

  • Addition of quotation marks in parse_kraken2report.nf prevents failure of the pipeline when using a taxon with space (e.g. Homo sapiens) with the tax2filter parameter

PR 34

Improving detaxizer by making the workflow more modular and enabling bbduk as second tool for classification. Also turning off blastn validation by default (too resource intensive for a default setting). Further smaller improvements see below.

Introduction of bbduk into the classification step

  • To increase the capabilities of detaxizer bbduk was introduced
  • The summary step was adapted to this change

Making blastn optional

  • blastn is now optional as it is very resource intensive (especially in terms of time) when many reads are classified

Making fastp optional

  • fastp removed duplicates from the files by default, which were then not part of the classification step and therefore not filtered (except if the filter_trimmed parameter was used)
  • the removal of duplicates can be turned on by setting fastp_eval_duplication

Output of removed reads

  • If the filter is used, then one can now optionally give out the removed reads in separate files using the output_removed_reads flag

Optional classification

  • Filtered and removed reads can now be optionally classified by kraken2 using the classification_kraken2_post_filtering flag

PR 39

Added generation of samplesheet for MAG, Taxprofiler by @Joon-Klaps

PR 42

Template update for nf-core/tools v3.0.2

jannikseidelQBiC and others added 30 commits April 4, 2024 14:33
Important! Template update for nf-core/tools v2.14.1
Fix for bug #32 by addition of quotation marks
@jannikseidelQBiC
Copy link
Collaborator Author

The failing test is due to the master branch not having this in the download_pipeline.yaml and the pipeline not supporting stub run. This is fixed in this version.

.nf-core.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
docs/images/Detaxizer_metro_workflow.svg Outdated Show resolved Hide resolved
modules/local/rename_fastq_headers_after.nf Outdated Show resolved Hide resolved
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite my many comments, I do not see any blockers here :)

.nf-core.yml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
workflows/detaxizer.nf Outdated Show resolved Hide resolved
workflows/detaxizer.nf Show resolved Hide resolved
workflows/detaxizer.nf Outdated Show resolved Hide resolved
workflows/detaxizer.nf Outdated Show resolved Hide resolved
workflows/detaxizer.nf Outdated Show resolved Hide resolved
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG now @jannikseidel !

@jannikseidelQBiC jannikseidelQBiC merged commit 69f308c into master Nov 8, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants