Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/biocat vocab #6

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Conversation

markdoerr
Copy link
Contributor

This is a new version of the demo biocatalysis vocabulary, based on the current template.

@markdoerr
Copy link
Contributor Author

Hi @dalito ,

what was again the cause of this error ? (I added the ID ranges in the idranges.toml file)

(or was it the missing multi-vocab support ?)

  File "/opt/hostedtoolcache/Python/3.11.8/x64/lib/python3.11/site-packages/voc4cat/convert_043.py", line 91, in extract_concepts_and_collections
    raise ConversionError(msg) from exc
voc4cat.utils.ConversionError: Concept processing error likely at sheet <Worksheet "Concepts">, row 3, and has error: 1 validation error for Concept
__root__
  ID of IRI https://example.org/voc4cat_biocatalysis/0000001 is not in allowed ID range(s) of actor "0000-0003-3270-6895" (from provenance). (type=value_error)
Error: Process completed with exit code 1.

@markdoerr
Copy link
Contributor Author

Hi @dalito,
should I first make a commit with the new idrange.toml file and then add the excel sheet after the pull request is approved ?

@dalito
Copy link
Member

dalito commented Feb 20, 2024

Yes. The idranges.toml must be merged first. But there is already:

[[vocabs.biocatalysis_demo.id_range]]
first_id = 1
last_id = 200
gh_name = "markdoerr"
orcid = ""
ror_id = ""

This lacks an ORCID but you used ORCID in Excel. You may use the gh-name in Excel as well.

...or update idranges.toml with ORCID in another PR.

@dalito dalito merged commit d9b4de2 into nfdi4cat:main Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants