Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move submission to a cli based 2-step process #57

Open
HLWeil opened this issue Aug 7, 2024 · 1 comment
Open

Move submission to a cli based 2-step process #57

HLWeil opened this issue Aug 7, 2024 · 1 comment
Assignees
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature

Comments

@HLWeil
Copy link
Member

HLWeil commented Aug 7, 2024

Just discovered that the invenio validation package does not behave correctly #56. Currently looking for fixes, but would like some extra security in shape of unit tests which check the correct working of the validation package. Is there any place for this currently?

@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Aug 7, 2024
@HLWeil HLWeil added Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature and removed Status: Needs Triage This item is up for investigation. labels Aug 7, 2024
@kMutagene
Copy link
Member

I see pros and cons for this.

On one hand, validation packages such as invenio are so integral to out tool stack that maybe we should include further testing in this repo's CI pipelines. On the other hand, this repo is a registry, validation packages are just provided 'as-is'. In this framework, the author of a package has to make sure that it works, not the author of the registry. Imagine something like npm or nuget being responsible to run further testing if the packages "work" (whatever that means).

So i think at the end of the day we want to transition from a one-step submission process - that is, people submitting single script files to this repo - to a two-step submission process, where validation packages are their own repos with full testing pipelines and whatnot. submission should then be handled via a cli tool in a predefined format. This is basically what all the examples for package registries i mentioned do. But this is a lot of extra work and i do not think something we want to tackle this year.

So the intermediate solution i would suggest here would be adding tests for invenio specifically, and leave testing to authors on all other submissions.

@kMutagene kMutagene moved this to Backlog in ARCStack Aug 20, 2024
@kMutagene kMutagene changed the title Is there a place to add tests that test that the tests test correctly Move submission to a cli based 2-step process Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Request This item is confirmed by the maintainers to be a request for a new feature
Projects
Status: Backlog
Development

No branches or pull requests

2 participants