-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented segregation by network #612
Conversation
Hi @SilverFire Just to let you know that I saw this but I'm really, really lacking time those days. I'll take a look as soon as possible. |
No worries, take your time 🙌 I have already combined this PR together with #610 and deployed them on my production. |
@buchdag did you have a chance to check this PR? |
@SilverFire not yet :/ |
@SilverFire this will have to be rebased against #647 since it has been merged to master 😃 |
53f25e5
to
8dbe02d
Compare
Ok sorry for the delay, I just took a look and it's mostly good, here are my remarks:
As this is a pretty substantial feature, would you mind if I merged it to |
As you wish |
Ok so about the
Got that right ? Does the feature work as intended if the proxied container is connected to more than one network ? |
That's absolutely correct! |
Yes, it does:
We iterate over all networks of the container |
LGTM for a merge to |
Renamed. Will add docs lated |
Hi, @buchdag!
This pull-request implements the discussion we've started in #571
I've introduced a new env variable for LE container
MUST_BE_CONNECTED_WITH_NETWORK
, that limits the LE scope to containers, included only in the specified network. The tests are included.Could you review this pull request, please? If it seems acceptable to you, I will add the necessary documentation. Thank you!