Added the health status from healthcheck to RuntimeContainer struct #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @free6k What happen for containers that do not have a healhcheck ? |
|
@buchdag Nothing, will work as worked before this pr, if you will add healthcheck, then it check status |
|
@free6k I don't know what happened to your branch but could you try to cleanup the commit history so this can be reviewed ? |
|
@buchdag done |
|
Hi, any intention on merge this? |
|
It would be great to merge this. Feature is really desired! |
buchdag
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added right work for containers with enabled healthchecks
Now can know and work with Health Status in the container state