Add support to pull data from multiple docker endpoints (e.g. swarm) #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix getContainers
# Conflicts: # internal/generator/generator.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to request container data from multiple docker endpoints. For example in swarm you now can get containers information from all nodes at once.
Main idea is that
endpointparameter refers to local docker node for which docker-gen generates configs. And theswarm-nodeparameters define additional docker nodes from which docker-gen pulls containers information.Back compatability preserved. If no
swarm-nodestated then docker-gen collects information only from local docker endpoint defined byendpointparameter.In case when stated at least one
swarm-nodeparameter docker-gen will collect containers information from swarm-node list. And useendpointonly for "controlling" purpose (e.g. to notify containers).Root use-case for this PR is to make possible for projects like nginx-proxy to have full information across all swarm cluster.