Skip to content

Commit

Permalink
test: improve test
Browse files Browse the repository at this point in the history
  • Loading branch information
ngocnhan-tran1996 committed Jul 30, 2024
1 parent 3f7ba0c commit df46362
Show file tree
Hide file tree
Showing 2 changed files with 84 additions and 0 deletions.
7 changes: 7 additions & 0 deletions spring-jdbc-oracle-test/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,13 @@
<version>${revision}</version>
</dependency>

<dependency>
<groupId>com.tngtech.archunit</groupId>
<artifactId>archunit</artifactId>
<version>1.3.0</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-data-jpa</artifactId>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
package io.spring.jdbc.oracle;

import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.classes;

import com.tngtech.archunit.core.importer.ClassFileImporter;
import com.tngtech.archunit.core.importer.ImportOption.DoNotIncludeTests;
import com.tngtech.archunit.lang.ArchRule;
import io.spring.jdbc.oracle.converter.GenericOracleConverter;
import io.spring.jdbc.oracle.converter.OracleConverter;
import io.spring.jdbc.oracle.mapper.Mapper;
import java.util.List;
import org.junit.jupiter.api.Test;
import org.springframework.jdbc.core.SqlReturnType;
import org.springframework.jdbc.core.SqlTypeValue;

class ArchitectureTest {

private static final String BASE_PACKAGE = "io.spring.jdbc.oracle";

@Test
void reside_in_a_package_rule() {

var importedClasses = new ClassFileImporter()
.withImportOption(new DoNotIncludeTests())
.importPackages(BASE_PACKAGE);

ArchRule genericOracleConverterRule = classes()
.that()
.implement(GenericOracleConverter.class)
.should()
.haveSimpleNameEndingWith(GenericOracleConverter.class.getSimpleName())
.andShould()
.resideInAPackage(BASE_PACKAGE + ".converter.support");

ArchRule oracleConverterRule = classes()
.that()
.implement(OracleConverter.class)
.should()
.haveSimpleNameEndingWith(OracleConverter.class.getSimpleName())
.andShould()
.resideInAPackage(BASE_PACKAGE + ".converter.support");

ArchRule mapperRule = classes()
.that()
.implement(Mapper.class)
.should()
.haveSimpleNameEndingWith(Mapper.class.getSimpleName())
.andShould()
.resideInAPackage(BASE_PACKAGE + ".mapper");

ArchRule typeValueRule = classes()
.that()
.implement(SqlTypeValue.class)
.should()
.haveSimpleNameEndingWith("TypeValue")
.andShould()
.resideInAPackage(BASE_PACKAGE + ".parameter.input");

ArchRule returnTypeRule = classes()
.that()
.implement(SqlReturnType.class)
.should()
.haveSimpleNameEndingWith("ReturnType")
.andShould()
.resideInAPackage(BASE_PACKAGE + ".parameter.output");

List.of(
genericOracleConverterRule,
oracleConverterRule,
mapperRule,
typeValueRule,
returnTypeRule
)
.forEach(rule -> rule.check(importedClasses));
}

}

0 comments on commit df46362

Please sign in to comment.