[PRMP-1286] Change create fhir response to return json

nhsconnect · Jan 3, 2025 · 4e3de59 · 4e3de59
1 parent cfe6c2b
commit 4e3de59
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/lambdas/models/fhir/R4/nrl_fhir_document_reference.py b/lambdas/models/fhir/R4/nrl_fhir_document_reference.py
@@ -43,7 +43,7 @@ class ContentStabilityExtensionCoding(Coding):
 
 
 class ContentStabilityExtensionValueCodeableConcept(CodeableConcept):
-    coding: List[ContentStabilityExtensionCoding] = ContentStabilityExtensionCoding()
+    coding: List[ContentStabilityExtensionCoding] = [ContentStabilityExtensionCoding()]
 
 
 class ContentStabilityExtension(Extension):

diff --git a/lambdas/services/nrl_get_document_reference_service.py b/lambdas/services/nrl_get_document_reference_service.py
@@ -48,7 +48,7 @@ def handle_get_document_reference_request(self, document_id, bearer_token):
 
     def create_document_reference_fhir_response(
         self, document_reference: DocumentReference, presign_url: str
-    ) -> dict:
+    ) -> str:
         document_details = Attachment(
             url=presign_url,
             title=document_reference.file_name,
@@ -61,7 +61,7 @@ def create_document_reference_fhir_response(
                 attachment=document_details,
             )
             .create_fhir_document_reference_object()
-            .model_dump(exclude_none=True)
+            .model_dump_json(exclude_none=True)
         )
         return fhir_document_reference
 

diff --git a/lambdas/tests/unit/services/test_nrl_get_document_reference_service.py b/lambdas/tests/unit/services/test_nrl_get_document_reference_service.py
@@ -1,3 +1,5 @@
+import json
+
 import pytest
 from enums.patient_ods_inactive_status import PatientOdsInactiveStatus
 from services.nrl_get_document_reference_service import NRLGetDocumentReferenceService
@@ -153,7 +155,7 @@ def test_create_document_reference_fhir_response(patched_service):
     actual = patched_service.create_document_reference_fhir_response(
         create_test_doc_store_refs()[0], FAKE_URL
     )
-    assert actual["content"][0]["attachment"]["url"] == FAKE_URL
+    assert json.loads(actual)["content"][0]["attachment"]["url"] == FAKE_URL
 
 
 def test_user_allowed_to_see_file_happy_path(patched_service, mock_fetch_user_info):