PRMDR-168

Changing internal eror code to 500 from 400
nhsconnect · Oct 20, 2023 · 99c98ac · 99c98ac
1 parent cc6485c
commit 99c98ac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lambdas/handlers/back_channel_logout_handler.py b/lambdas/handlers/back_channel_logout_handler.py
@@ -37,7 +37,7 @@ def logout_handler(token):
     except ClientError as e:
         logger.error(f"Error logging out user: {e}")
         return ApiGatewayResponse(
-            400, """{ "error":"Internal error logging user out"}""", "POST"
+            500, """{ "error":"Internal error logging user out"}""", "POST"
         ).create_api_gateway_response()
     except AuthorisationException as e:
         logger.error(f"error while decoding JWT: {e}")

diff --git a/lambdas/tests/unit/handlers/test_back_channel_logout_handler.py b/lambdas/tests/unit/handlers/test_back_channel_logout_handler.py
@@ -103,7 +103,7 @@ def test_back_channel_logout_handler_invalid_jwt_returns_400(mock_oidc_service,
     mock_oidc_service.asset_called_with(mock_token)
 
 
-def test_back_channel_logout_handler_boto_error_returns_400(mocker, mock_oidc_service, monkeypatch):
+def test_back_channel_logout_handler_boto_error_returns_500(mocker, mock_oidc_service, monkeypatch):
     monkeypatch.setenv("OIDC_CALLBACK_URL", "mock_url")
     monkeypatch.setenv("AUTH_DYNAMODB_NAME", "mock_dynamo_name")
     mock_token = "mock_token"
@@ -118,7 +118,7 @@ def test_back_channel_logout_handler_boto_error_returns_400(mocker, mock_oidc_se
     )
 
     expected = ApiGatewayResponse(
-        400, """{ "error":"Internal error logging user out"}""", "POST"
+        500, """{ "error":"Internal error logging user out"}""", "POST"
     ).create_api_gateway_response()
 
     actual = lambda_handler(build_event_from_token(mock_token), None)