Prmdr 273 feature (DONT MERGE) #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes for the tests
WIP moving around then code a bit so it works for dev and pre-prod
WIP more refactoring to keep code for dev/password login and pre-prod/smartcard login seperate
WIP fixing the tests following big refactor; only one test is still failing and that's for token handler test and we're cool with that as there's still more work to do
WIP more test fixes
Finally fixed all tests
Commenting unused code to get this deployed
Removing unnecessary comment
Adding SSM service to allow the Token Handler to get the required params in one place - jwt private key and the role / ODS codes we need
…ory into prmdr-378 merge branch prmdr-378
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
* updated pcse logic inline with understanding * removed errors from permitted_rle.py * valid code readded to role geenration * testing ssm param store for ods/role codes * fixed ssm token param request call * added addtional logging for token handler params * converted ssm repsonses to arrays * updated to correct service reference not import * added additional logging * code tidy * auth configurations for the ui * permitted smart roles removed as enum and now uses param store * UI changes added for Role workflow detection * removing screenshots from cypress repo * Alter auth handler to manage new data model in JWT * removed last remaining traces of PermittedRole enum in tokenHandler logic * changed admin role ssm getter to return as single string rather than array * changed from using match stratergy to standard if chain on role detection * testing gp_clincal param store get with aditional logging * changed PCSE access routes in authriser lambda to all * refactord to use REPOSITOYR_ROLE ENUM instead of AUTH_ROLE on UI * Code review comments and remove old login code * Correct imports * Correct imports again --------- Co-authored-by: Scott Alexander <scott.alexander@madetech.com> Co-authored-by: Richard Smith <richard.smith33@nhs.net>
SRAlexander
had a problem deploying
to
development
GitHub Actions
Failure
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
* Add gp clinical access policy * Update auth policy to be dynamic * Add test skip * Fix path bug typo * Add missing gp clinical role * Remove search patient details test code * Reset org hardcoding * Remove json logging for user_roles * Fix param order bug on authoriser * Restore path variable in auth * Fix token req handler * Add test org * Add missing path var * Remove test code * Simplify access policy logic * Invert deny resource logic * Update authoriser role to repository role * Add ods policy to patient search lambda * Fix bug in pds test * Fix broken pds file * Skip failing unit tests * Add search patient lgs * add report lambda to actions (#122) * Alter exception name * Missing items from previous commit * added clinical admin restrictions to clinical admin role * code review changes applied * fixed ssm service switch ove rin authroiser handler * addional logging + fix for patient search lambda * updated name on ods code via token decoded * correct auth token header name * updated aut header location * added addtional loggeing to authoriser lambda * fixed public key getter from Param Store * added additional logging for debugging * added matching logging in authoriser lambda * enabled public key decreption on ssm get request * testing patient_test_data with pcse org ods * added logging for patient search service * updated patient_details model to include gp ods code * updated end dates on mock data to 2025 to test org retrieval * model logging added * model logging added * further logging added * logging testing * removed ge tof specific class value * attepting class access via dict syntax * using model_dups to get data as dictionary * attempting to access pythonic class properties * hijacking json dump instead of model dump * model updates + simplification * model updates + simplification * reversion * return typing fix * reenabled ods check * additional logging added * additional logging added * validation fix * updated response logic around ods on patientSearch * syntax fix * moved active to post model creation checking * moved active to post model creation checking * added addional mock data for different scenerios to manually test * testing as gp_admin role * testing not active patient * removed value error for whent here's no active GP, we require a blank responce for pcse users * renamed get ods to get active * additional logging added for pcse odscode * testing null string check failure * testing null string check failure * testing null string check failure * enum syntax fix and removed logging * added token handler correction + is_active optimisations * fix for pcse optimisations on token handler * token handler logging added * removed debug logging, suddenly started working * get is active status fix * code review tidy comments --------- Co-authored-by: Rio Knightley <rio.knightley2@nhs.net> Co-authored-by: NogaNHS <127490765+NogaNHS@users.noreply.github.com> Co-authored-by: Richard Smith <richard.smith33@nhs.net> Co-authored-by: Scott Alexander <scott.alexander@madetech.com>
* Add gp clinical access policy * Update auth policy to be dynamic * Add test skip * Fix path bug typo * Add missing gp clinical role * Remove search patient details test code * Reset org hardcoding * Remove json logging for user_roles * Fix param order bug on authoriser * Restore path variable in auth * Fix token req handler * Add test org * Add missing path var * Remove test code * Simplify access policy logic * Invert deny resource logic * Update authoriser role to repository role * Add ods policy to patient search lambda * Fix bug in pds test * Fix broken pds file * Skip failing unit tests * Add search patient lgs * add report lambda to actions (#122) * Alter exception name * Missing items from previous commit * added clinical admin restrictions to clinical admin role * code review changes applied * fixed ssm service switch ove rin authroiser handler * addional logging + fix for patient search lambda * updated name on ods code via token decoded * correct auth token header name * updated aut header location * added addtional loggeing to authoriser lambda * fixed public key getter from Param Store * added additional logging for debugging * added matching logging in authoriser lambda * enabled public key decreption on ssm get request * testing patient_test_data with pcse org ods * added logging for patient search service * updated patient_details model to include gp ods code * updated end dates on mock data to 2025 to test org retrieval * model logging added * model logging added * Remove radio buttons from confirmation button * UI finishing touches * Update jest tests for patient result page * Add unit test for when active field is not populated on patient model * Code review changes --------- Co-authored-by: Rio Knightley <rio.knightley2@nhs.net> Co-authored-by: NogaNHS <127490765+NogaNHS@users.noreply.github.com> Co-authored-by: Scott Alexander <scott.alexander@madetech.com>
Unit test fixes against code changes --------- Co-authored-by: Richard Smith <richard.smith33@nhs.net>
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.