Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prmdr 369 and 372 #121

Merged
merged 51 commits into from
Nov 3, 2023
Merged

Prmdr 369 and 372 #121

merged 51 commits into from
Nov 3, 2023

Conversation

joefong-nhs
Copy link
Contributor

No description provided.

NogaNHS and others added 30 commits October 24, 2023 14:27
@NogaNHS
prmdr-370 initial commit
c576556
@NogaNHS
prmdr-370 added checks to validtors
ae1933a
@NogaNHS
prmdr-370 fix pydantic syntax
f061ebf
@NogaNHS
fix unit test
e7ae729
@NogaNHS
small fixes
f57cd1a
@NogaNHS
add unit tests
86553d6
@NogaNHS
unit tests
7ee1d8d
@joefong-nhs
[PRMDR-372] Add model for bulk upload status, add test for parsing re…
1ab7ee5 
…cords
@joefong-nhs
[PRMDR-372] Modify upload status model for easier interaction with dy…
53b1913 
…namodb
@joefong-nhs
[PRMDR-372] rebase with prmdr-370
b2ec60b
@joefong-nhs
[PRMDR-372] Add unit test for bulk upload reporting, remove unwanted …
de0e8c6 
…comments
@joefong-nhs
[PRMDR-372] Fix mismatch of env var
aa76b10
@joefong-nhs
[PRMDR-372] fix misspelling, fix missing by_alias=True
8f28dbc
@RioKnightleyNHS
Add bulk upload validation for virus scanner
32cf376
@joefong-nhs
[PRMDR-372] hotfix to use mock pds service in LG validation
c70f223
@joefong-nhs
[PRMDR-372] replace mocked pds patient ods code
8f2a7e1
@joefong-nhs
Merge branch 'main' into prmdr-372-subtask
8da67d6
@joefong-nhs
[PRMDR-372] Fix unit test that was broken during merge
3f38eb0
@joefong-nhs
[PRMDR-372] run formatter
ab59227
@joefong-nhs
Merge branch 'prmdr-369-squash' into prmdr-372-subtask
2420c3f
@joefong-nhs
Merge branch prmdr-369-squash into prmdr-372-subtask
16caf7d
@joefong-nhs
[PRMDR-372] Fix import error
996e667
@joefong-nhs
[PRMDR-372] modify bulk upload lambda
4665df1
@joefong-nhs
[PRMDR-372] Amend send_message_with_nhs_number_attr to have delay_sec…
df60d5a 
…ond default as 0 instead of None
@RioKnightleyNHS
Add get object tag unit testt
080d563
@joefong-nhs
[PRMDR-369] Add unhappy path test for get_tag_value, minor refactoring
d296777
@joefong-nhs
[PRMDR-369] Replace literal strings with enum / constants for virus s…
2162fc0 
…can result. Amend logic of check_virus_result to fit ticket description
@joefong-nhs
[PRMDR-369] Add unit tests for check_virus_result, add logic to handl…
0f44e81 
…e the case when required file not exist in S3
@joefong-nhs
[PRMDR-372] Amend mock test data of Bulk Upload to fit default mock p…
a0d96a4 
…atient of mock pds service
@joefong-nhs
[PRMDR-372] Add unit tests for bulk upload service
a4902d5
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 1, 2023 14:40 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 2, 2023 12:35 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs temporarily deployed to development November 2, 2023 12:35 — with GitHub Actions Inactive
@joefong-nhs joefong-nhs merged commit f0aafa8 into main Nov 3, 2023
10 checks passed
@richbyrne-nhs richbyrne-nhs deleted the prmdr-369-and-372 branch November 20, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NogaNHS NogaNHS NogaNHS left review comments

@abbas-khan10 abbas-khan10 abbas-khan10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joefong-nhs @abbas-khan10 @NogaNHS @RioKnightleyNHS