Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prmdr 452: Back button functionality on the search screens #150

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Prmdr 452: Back button functionality on the search screens #150

merged 7 commits into from
Nov 21, 2023

Conversation

thisusernameisnowtaken
Copy link
Contributor

Start the login process when the user clicks the back button whilst on the search screen.
If the user is not on the search screen, the back button should take them back one page.

AlexHerbertNHS
AlexHerbertNHS previously requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@AlexHerbertNHS AlexHerbertNHS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine and I've tested it; seems to work as expected, but does not delete previous session, allowing me to spam sessions. This is probably a bad idea; request changes to delete previous sessions as part of the logout process

image

@thisusernameisnowtaken
Copy link
Contributor Author

Looks fine and I've tested it; seems to work as expected, but does not delete previous session, allowing me to spam sessions. This is probably a bad idea; request changes to delete previous sessions as part of the logout process

image

This has been dicussed and a new ticket to check if a user has an existing JWT before forwarding to the login handler will be done at a future date.

@thisusernameisnowtaken thisusernameisnowtaken dismissed AlexHerbertNHS’s stale review November 21, 2023 14:56

A fix for this issue is in a new ticket

@thisusernameisnowtaken thisusernameisnowtaken merged commit 502862c into main Nov 21, 2023
29 checks passed
@thisusernameisnowtaken thisusernameisnowtaken deleted the prmdr-452 branch November 21, 2023 14:57
AlexHerbertNHS
AlexHerbertNHS reviewed Nov 21, 2023
View reviewed changes
app/src/components/generic/backButton/BackButton.test.tsx

describe('BackButton', () => {
it('navigates to previous page when clicking the back button', async () => {
it('navigates to previous page when clicking the back buttonand not on the search pages', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHerbertNHS AlexHerbertNHS AlexHerbertNHS left review comments

@RioKnightleyNHS RioKnightleyNHS RioKnightleyNHS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thisusernameisnowtaken @AlexHerbertNHS @RioKnightleyNHS