Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRMDR-538 Remove Feedback Link (Response from Ifey) #177

Merged
merged 1 commit into from
Dec 1, 2023
Merged

PRMDR-538 Remove Feedback Link (Response from Ifey) #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions app/src/components/layout/phaseBanner/PhaseBanner.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,15 @@ describe('PhaseBanner', () => {
expect(screen.getByText('New Service')).toBeInTheDocument();

expect(screen.getByText(/Your/i)).toBeInTheDocument();
expect(screen.getByText('feedback')).toBeInTheDocument();
expect(screen.getByText(/feedback/i)).toBeInTheDocument();
expect(screen.getByText(/will help us to improve this service./i)).toBeInTheDocument();
});
});
describe('Navigation', () => {
it('renders an external link with a feedback href', () => {
it.skip('renders an external link with a feedback href', () => {
/**
* Remove skip once feedback link attribute has been verified by Product team
*/
render(<PhaseBanner />);
const feedbackLink = screen.getByRole('link', {
name: 'feedback',
Expand Down
11 changes: 1 addition & 10 deletions app/src/components/layout/phaseBanner/PhaseBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,7 @@ function PhaseBanner() {
New Service
</strong>
<span className="govuk-phase-banner__text">
{'Your '}
<a
className="govuk-link"
href="https://digital.nhs.uk/about-nhs-digital/contact-us#nhs-digital-service-desks"
target="_blank"
rel="noreferrer"
>
feedback
</a>
{' will help us to improve this service.'}
Your feedback will help us to improve this service.
</span>
</p>
</div>
Expand Down
Loading