Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRMDR-464 Remove hardcoded port numbers #201

Merged
merged 46 commits into from
Dec 18, 2023
Merged

PRMDR-464 Remove hardcoded port numbers #201

merged 46 commits into from
Dec 18, 2023

Conversation

joefong-nhs
Copy link
Contributor

  • Remove hardcoded port numbers 80 and 8080 (at nginx.conf and docker-compose.yml). Replace by reading the port number from AWS parameter store or local .env file instead.
  • Remove hardcoded port number 3000 from multiple file. Replace by reading from github variable or local.env file instead.
  • Update README.md and .env.template to reflect the changes

Note: This PR has pulled in the updated cypress tests from another ticket PRMDR-485, so better not to merge this until PRMDR-485 is merged to main.

Scott Alexander and others added 30 commits December 4, 2023 13:52
boiler plate for smoketest GitHub action
baa7d7a
yml errors removed
2c511de
cypress smoketesting configuration changes
8ee1ddb
@RioKnightleyNHS
Merge branch 'main' into prmdr_485
23d6833
@RioKnightleyNHS
Migrate Cypress baseUrl to cross-env
a9522c5
@RioKnightleyNHS
Update cypress smoke workflow to use cross-env
fb2d150
@RioKnightleyNHS
Amend cypress cross-env
7096e55
@RioKnightleyNHS
Add final adjustments to smoke test workflow
ace6e69
@RioKnightleyNHS
Add sandbox input to smoke test workflow
93cf719
@RioKnightleyNHS
Add checkout input for smoke test workflow
e451f1e
@RioKnightleyNHS
Fix input typo in build branch
cf5ed06
@RioKnightleyNHS
Fix null on url
109dfda
@RioKnightleyNHS
Update input verbiage
fec4c91
@RioKnightleyNHS
Add cypress/grep package
5f537af
@RioKnightleyNHS
Fix missing env variables
1861a20
@RioKnightleyNHS
Sandbox input change to url
7a3d896
@RioKnightleyNHS
Update other input urls
4ca8d60
@RioKnightleyNHS
Restore cypress env variable
e0494e1
@RioKnightleyNHS
Change cypress input env
278835a
@RioKnightleyNHS
Update URL test
59248be
@RioKnightleyNHS
Remove cross-env test
0b24b4e
@RioKnightleyNHS
Fix inconsistencies in trailing slashes
6b1a0e6
@RioKnightleyNHS
Add new smoke test layout
d38d8ec
@RioKnightleyNHS
Add first smoke test
42dbf80
@RioKnightleyNHS
Add grepTags for regression and smoke cypress tests
47967ca
@RioKnightleyNHS
Update grepTags workflow env
96e90f5
@RioKnightleyNHS
Alter cy.visit with new config usage
41520c9
@RioKnightleyNHS
Fix grepTags on other workflows
a6fddd1
@joefong-nhs
[PRMDR-464] (WIP) Remove hardcoded port number from nginx.conf and do…
8b87048 
…cker related files
@joefong-nhs
[PRMDR-464] Edit github actions to read env var CONTAINER_PORT before…
7c8a064 
… running `docker build`
@joefong-nhs joefong-nhs marked this pull request as ready for review December 13, 2023 15:17
carlsmith101
carlsmith101 suggested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@carlsmith101 carlsmith101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@joefong-nhs joefong-nhs merged commit da12640 into main Dec 18, 2023
14 checks passed
@joefong-nhs joefong-nhs deleted the PRMDR-464 branch December 18, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexHerbertNHS AlexHerbertNHS AlexHerbertNHS approved these changes

@carlsmith101 carlsmith101 carlsmith101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joefong-nhs @carlsmith101 @AlexHerbertNHS @RioKnightleyNHS