PRMDR-803 + 770 update BSOL download journey #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RachelHowellNHS
had a problem deploying
to
development
GitHub Actions
Failure
RachelHowellNHS
had a problem deploying
to
development
GitHub Actions
Failure
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
SRAlexander
changed the title
SRAlexander
requested changes
May 20, 2024
app/cypress/e2e/0-ndr-core-tests/gp_user_workflows/download_lloyd_george_workflow.cy.js
Outdated
Show resolved
Hide resolved
app/cypress/e2e/0-ndr-core-tests/gp_user_workflows/download_lloyd_george_workflow.cy.js
Outdated
Show resolved
Hide resolved
app/cypress/e2e/0-ndr-core-tests/gp_user_workflows/download_lloyd_george_workflow.cy.js
Outdated
Show resolved
Hide resolved
app/cypress/e2e/0-ndr-core-tests/gp_user_workflows/download_lloyd_george_workflow.cy.js
Outdated
Show resolved
Hide resolved
...c/components/blocks/_lloydGeorge/lloydGeorgeDownloadComplete/LloydGeorgeDownloadComplete.tsx
Outdated
Show resolved
Hide resolved
SRAlexander
requested changes
May 20, 2024
| self.download_documents_to_be_zipped(documents) | ||
| self.upload_zip_file() | ||
|
|
||
| shutil.rmtree(self.temp_downloads_dir) |
There was a problem hiding this comment.
It's not clear what these do, can we add a comment?
SRAlexander
approved these changes
May 21, 2024
RachelHowellNHS
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recording on ticket