Prmdr 336 subtask #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: NogaNHS <noga.sasson1@nhs.net>
…erialise/deserialise with field names in NHS spec
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
AlexHerbertNHS
approved these changes
Oct 10, 2023
| logger.error(str(e)) | ||
|
|
||
|
|
||
| def download_metadata_from_s3(staging_bucket_name: str, metadata_filename: str): |
There was a problem hiding this comment.
Could this method be moved to an inherited version of the S3service to keep this file a little cleaner?
| ) -> None: | ||
| sqs_service = SQSService() | ||
|
|
||
| for staging_metadata in staging_metadata_list: |
There was a problem hiding this comment.
Could this method be moved to an inherited version of the SQS service to keep this file a little cleaner?
AlexHerbertNHS
suggested changes
Oct 10, 2023
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
joefong-nhs
temporarily deployed
to
development
GitHub Actions
Inactive
AlexHerbertNHS
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.