Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRMDR-264 View a Lloyd George Document e2e tests #87

Merged
merged 6 commits into from
Oct 13, 2023
Merged

PRMDR-264 View a Lloyd George Document e2e tests #87

merged 6 commits into from
Oct 13, 2023

Conversation

carlsmith101
Copy link
Contributor

No description provided.

@carlsmith101 carlsmith101 temporarily deployed to development October 11, 2023 15:09 — with GitHub Actions Inactive
@carlsmith101 carlsmith101 temporarily deployed to development October 12, 2023 14:06 — with GitHub Actions Inactive
premnhs4
premnhs4 reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@premnhs4 premnhs4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :

  • Cleaned unwanted Cypress folder
  • Introduced custom commands.
  • just couple of queries left.
  • Not sure why files in src was updated ( ie, pdfViewer.tsx & LloydGeorgeRecordPage.tsx) ?

app/cypress/e2e/0-ndr-core-tests/gp_view_lloyd_george_workflow.cy.js Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
app/cypress/support/e2e.ts Show resolved Hide resolved
@carlsmith101 carlsmith101 temporarily deployed to development October 13, 2023 13:01 — with GitHub Actions Inactive
@carlsmith101 carlsmith101 requested a review from premnhs4 October 13, 2023 13:04
premnhs4
premnhs4 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@premnhs4 premnhs4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlsmith101 carlsmith101 merged commit 78edf3f into main Oct 13, 2023
7 checks passed
@richbyrne-nhs richbyrne-nhs deleted the PRMDR-264 branch November 20, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premnhs4 premnhs4 premnhs4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlsmith101 @premnhs4 @RachelHowellNHS