PRMT-4462 #60
Merged
PRMT-4462 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martin-nhs
commented
Feb 1, 2024
martin-nhs
commented
- Enabled HTML escaping via GSON.
- Created unit tests to prove it is working.
- Unit and Integration tests pass successfully.
martin-nhs
requested review from
MohammadIqbalAD-NHS,
AndyFlintNHS and
chrisbloe-nhse
chrisbloe-nhse
approved these changes
Feb 1, 2024
Comment on lines
-33
to
+32
| .toJson(this); | ||
| return new GsonBuilder().create().toJson(this); |
There was a problem hiding this comment.
I notice the 3 classes; ReRegistrationEvent, ActiveSuspensionsMessage and AuditMessage all have their own methods "toJsonString()" which does the same logic. Could this not be extracted out rather than being defined in 3 places?
There was a problem hiding this comment.
Will come back to this one and analyse further 😄 - good spot, though noting as technical debt - scope creep in terms of this ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.