Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFD-5941 Unify Deployment Pipelines and Improve Stage Visibility and Debugging #299

Merged
merged 1 commit into from
Jun 19, 2024
Merged

SFD-5941 Unify Deployment Pipelines and Improve Stage Visibility and Debugging #299

merged 1 commit into from
Jun 19, 2024

Conversation

mayank1211
Copy link
Contributor

@mayank1211 mayank1211 commented Jun 14, 2024 •
edited
Loading

  1. Combining Deployment Pipelines:
  • Unified the deployment pipelines for non-prod, demo, and prod environments into a single instance.
  1. Manual Approval Step:
  • Added a manual approval stage before the provisioning step.

@mayank1211 mayank1211 force-pushed the task/SFD-5941_Combined_jenkins_deployment_pipeline branch from ada55e7 to 952ba80 Compare June 14, 2024 12:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

rohith1122
rohith1122 reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@rohith1122 rohith1122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. LGTM apart from the commit message .
    Could you please add the ticket number like task: SFD-5941 Unify Deployment Pipelines and Improve Stage Visibility and Debugging.
  2. Did you test the pipeline ?

@mayank1211 mayank1211 changed the title Unify Deployment Pipelines and Improve Stage Visibility and Debugging SFD-5941 - Unify Deployment Pipelines and Improve Stage Visibility and Debugging Jun 18, 2024
@mayank1211 mayank1211 changed the title SFD-5941 - Unify Deployment Pipelines and Improve Stage Visibility and Debugging SFD-5941 Unify Deployment Pipelines and Improve Stage Visibility and Debugging Jun 18, 2024
@mayank1211
Copy link
Contributor Author

  1. LGTM apart from the commit message .
    Could you please add the ticket number like task: SFD-5941 Unify Deployment Pipelines and Improve Stage Visibility and Debugging.

    1. Did you test the pipeline ?

@rohith1122 Yeah - we have tested this in Non-prod env.

robertbryant-nhs
robertbryant-nhs approved these changes Jun 19, 2024
View reviewed changes
Copy link

@robertbryant-nhs robertbryant-nhs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as it's been tested, which I believe it has

@mayank1211 mayank1211 merged commit 52ad239 into master Jun 19, 2024
7 of 9 checks passed
@mayank1211 mayank1211 deleted the task/SFD-5941_Combined_jenkins_deployment_pipeline branch June 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertbryant-nhs robertbryant-nhs robertbryant-nhs approved these changes

@daonhs daonhs Awaiting requested review from daonhs

@kobl1nhs kobl1nhs Awaiting requested review from kobl1nhs

@rohith1122 rohith1122 Awaiting requested review from rohith1122

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank1211 @rohith1122 @robertbryant-nhs